Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i2s_stream.h - C++ / Arduino / Platformio compatibility (AUD-599) #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stasartcode
Copy link

I2S_STREAM_CFG_DEFAULT()
// FIXME OK -> C++ / Arduino / Platformio -> a value of type "int" cannot be used to initialize an entity of type "i2s_mode_t"
// -> change in .platformio\packages\framework-arduinoespressif32\tools\sdk\include\driver\driver\i2s.h - i2s_mode_t - I2S_MODE_MASTER_TX_RX = 13,
// FIXME OK -> C++ / Arduino / Platformio -> non-trivial-designated-initializers-not-supported -> the order of initialization needs to be in the exact order of declaration.

I2S_STREAM_CFG_DEFAULT()
// FIXME OK -> C++ / Arduino / Platformio -> a value of type "int" cannot be used to initialize an entity of type "i2s_mode_t" 
// -> change in .platformio\packages\framework-arduinoespressif32\tools\sdk\include\driver\driver\i2s.h - i2s_mode_t - I2S_MODE_MASTER_TX_RX = 13, 
// FIXME OK -> C++ / Arduino / Platformio -> non-trivial-designated-initializers-not-supported -> the order of initialization needs to be in the exact order of declaration.
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stasartcode stasartcode changed the title Update i2s_stream.h Update i2s_stream.h - C++ / Arduino / Platformio compatibility Jan 10, 2019
@projectgus projectgus changed the title Update i2s_stream.h - C++ / Arduino / Platformio compatibility Update i2s_stream.h - C++ / Arduino / Platformio compatibility (AUD-599) Jul 23, 2019
@Alvin1Zhang
Copy link
Collaborator

@stasartcode Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants