Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of ESP32-A1S-Audio-kit (AUD-3619) #764

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zhangtemplar
Copy link

It is based on information from

Tested with examples/player/pipeline_sdcard_mp3_control

Note only two keys (key 1 and key 2) are working.

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title Add support of ESP32-A1S-Audio-kit Add support of ESP32-A1S-Audio-kit (AUD-3619) Feb 14, 2022
@pierluigizagaria
Copy link

pierluigizagaria commented May 29, 2022

Thanks for sharing!
Is there anything that can be done to make the other buttons work?

@HengYongChao
Copy link
Contributor

HengYongChao commented May 31, 2022

@zhangtemplar

Thanks for your works!

Since the ESP32-A1S-Audio-kit is not an espressif official development board, this PR may need to be discussed.

@HengYongChao HengYongChao added the Type: New Feature New feature or request label May 31, 2022
@HengYongChao HengYongChao self-assigned this May 31, 2022
@pierluigizagaria
Copy link

I've tried to checkout at 2.4 version and do a merge with zhangtemplar/master but it's giving me some compilation error after the merge resolve.

../main/voip_app.c: In function 'app_main':
../main/voip_app.c:460:49: error: implicit declaration of function 'INPUT_KEY_DEFAULT_INFO'; did you mean 'ETH_PHY_DEFAULT_CONFIG'? [-Werror=implicit-function-declaration]
     input_key_service_info_t input_key_info[] = INPUT_KEY_DEFAULT_INFO();
                                                 ^~~~~~~~~~~~~~~~~~~~~~
                                                 ETH_PHY_DEFAULT_CONFIG
../main/voip_app.c:460:49: error: invalid initializer
../main/voip_app.c:476:58: error: 'INPUT_KEY_NUM' undeclared (first use in this function)
     input_key_service_add_key(input_ser, input_key_info, INPUT_KEY_NUM);
                                                          ^~~~~~~~~~~~~
../main/voip_app.c:476:58: note: each undeclared identifier is reported only once for each function it appears in
../main/voip_app.c:476:58: warning: passing argument 3 of 'input_key_service_add_key' makes integer from pointer without a cast [-Wint-conversion]
In file included from ../main/voip_app.c:24:
D:/Espressif/.espressif/esp-adf/components/input_key_service/include/input_key_service.h:109:125: note: expected 'int' but argument is of type 'input_key_service_info_t *' {aka 'struct <anonymous> *'} esp_err_t input_key_service_add_key(periph_service_handle_t input_key_handle, input_key_service_info_t *input_key_info, int add_key_num);
                                                                                                                         ~~~~^~~~~~~~~~~
cc1.exe: some warnings being treated as errors
ninja: build stopped: subcommand failed.
The terminal process "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -Command ninja " terminated with exit code: 1.

@pierluigizagaria
Copy link

pierluigizagaria commented Jun 10, 2022

Got the voip example working thanks to this PR. The sound quality is horrible. is it normal? is the sound quality acceptable for supported boards?

@zhangtemplar
Copy link
Author

@zhangtemplar

Thanks for your works!

Since the ESP32-A1S-Audio-kit is not an espressif official development board, this PR may need to be discussed.

Happy to discuss.

@zhangtemplar
Copy link
Author

Got the voip example working thanks to this PR. The sound quality is horrible. is it normal? is the sound quality acceptable for supported boards?

I didn't test the VoIP example. If you have the code, I may test it (it could be very slow as I am doing this for a hobby).

@zhangtemplar
Copy link
Author

Thanks for sharing! Is there anything that can be done to make the other buttons work?

I realized it is a malfunction of my board. When I compared my board to other's board of the model, my board lacked some resistor/capacitor for those buttons.

@nicola-lunghi
Copy link

Hi this will be really nice to have I have the same board

@nicola-lunghi
Copy link

@zhangtemplar I think you should sign the contributor agrement license.
Happy to take this on if it makes this board works I have 3 of them :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants