Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new parameter 'action' #15

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Conversation

binary1230
Copy link

@binary1230 binary1230 commented Mar 21, 2022

  • Allow specifying alternative commands to run other than idf.py build
  • Useful for using other esp-idf tools inside the docker container as part of Github CI builds.
  • Defaults to idf.py build
  • fixes Add support for parametrized build #2

Example: Building custom flash images as part of Github actions

      - name: Create Final Merged Binary
        uses: espressif/esp-idf-ci-action
        with:
          esp_idf_version: v4.4
          path: './build/'

          # 'command' is the new thing this PR adds
          command: esptool.py --chip esp32 merge_bin --fill-flash-size 4MB -o ../your_custom_file.bin @flash_args

notes:

  • Based on previous work by @BrianPugh
  • I tested this with just my local projects, not sure if there's other test suites that it should be run through/etc
  • Thanks everyone

- allows overriding the actual command executed in the container
- useful for running other build commands besides 'idf.py build'
- example: generating custom flash images, or using other SDK tools
@kumekay
Copy link
Collaborator

kumekay commented Apr 26, 2022

@binary1230 Thank you so much for the contribution!

I would only suggest naming the new parameter command instead of action`

Also, it looks like this closes #2 could you please add fixes #2 to the PR description?

@binary1230
Copy link
Author

changed and tested locally, works. should be good to go. thanks!

@kumekay kumekay merged commit 4346134 into espressif:main Apr 30, 2022
@kumekay
Copy link
Collaborator

kumekay commented Apr 30, 2022

@binary1230 Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for parametrized build
2 participants