Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WPA3 constants #61

Closed

Conversation

brunoro
Copy link
Contributor

@brunoro brunoro commented Oct 26, 2022

The wifi_constants.proto file esp-idf contains enum values describing the WPA2/WPA3 mixed mode and the WPA3 SAE modes. This PR appends the missing enum values to the proto file and to the corresponding Swift source.

The lack of theses constants caused issues when scanning for networks when any WPA3 network is available within the range of the ESP device. Connecting to WPA2/WPA3 networks works fine after the fix, with the ESP device selecting the WPA2 mode correctly.

iOS counterpart of espressif/esp-idf-provisioning-android#67

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@brunoro
Copy link
Contributor Author

brunoro commented Oct 26, 2022

ccing @vikas-chandra-mnnit for visibility

@brunoro brunoro changed the title feat: wpa3 support feat: WPA3 constants Oct 26, 2022
@vikas-chandra-mnnit
Copy link
Contributor

Hi @brunoro, thanks for your contribution. We will verify this PR on our end and update you soon. Thanks again and keep contributing :).

@vikas-chandra-mnnit
Copy link
Contributor

@brunoro This change does not affect searching or connecting with Wi-Fi during provisioning. Nevertheless, we will merge this change as it provides additional info about the security mode of the Wi-Fi network.

If you are still facing some issues without this change, please provide us with details of the problem and logs of the ESP device to look into.

@brunoro
Copy link
Contributor Author

brunoro commented Nov 3, 2022

This change does not affect searching or connecting with Wi-Fi during provisioning.

@vikas-chandra-mnnit that's not what we experienced in our project. Searching would work fine, but we weren't able to connect to neither WPA3-SAE nor WPA2/WPA3 mixed mode networks without the patch.

@vikas-chandra-mnnit
Copy link
Contributor

@brunoro I was able to connect with WPA2/WPA3 mixed mode networks. Can you send the logs for the ESP device to check which error you were facing during provisioning?

@brunoro
Copy link
Contributor Author

brunoro commented Nov 4, 2022

@vikas-chandra-mnnit you are absolutely right, sorry for the confusion. The issue was happening on our side only on Android. Feel free to close the pull request if the changes are not relevant.

My patch for esp-idf-provisioning-android was already merged some months ago and the issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants