Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp_hw_support/port/esp32/CMakeLists.txt specifies missing include directory (IDFGH-11581) #12700

Closed
3 tasks done
Hairy-Lee opened this issue Nov 30, 2023 · 2 comments
Closed
3 tasks done

esp_hw_support/port/esp32/CMakeLists.txt specifies missing include directory (IDFGH-11581) #12700

Hairy-Lee opened this issue Nov 30, 2023 · 2 comments
Assignees
@0xjakob
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally

Comments

@Hairy-Lee
Copy link

Hairy-Lee commented Nov 30, 2023 •
edited
Loading

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

./v5.1/components/esp_hw_support/port/esp32/private_include no longer exists (it was in v4.4 along with associated *.h).

However, it is still specified in ./v5.1/components/esp_hw_support/port/esp32/CMakeLists.txt on line 2:
target_include_directories(${COMPONENT_LIB} PUBLIC private_include)

When creating a JSON Compliation Database this non-existant folder subsequently gets added to compile_commands.json

https://github.com/espressif/esp-idf/tree/release/v5.1/components/esp_hw_support/port/esp32
https://github.com/espressif/esp-idf/blob/release/v5.1/components/esp_hw_support/port/esp32/CMakeLists.txt
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 30, 2023
@github-actions github-actions bot changed the title esp_hw_support/port/esp32/CMakeLists.txt specifies missing include directory esp_hw_support/port/esp32/CMakeLists.txt specifies missing include directory (IDFGH-11581) Nov 30, 2023
@0xjakob
Copy link
Contributor

0xjakob commented Dec 1, 2023

@Hairy-Lee Thanks for letting us know, we'll prepare a fix for this.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Dec 4, 2023
@0xjakob
Copy link
Contributor

0xjakob commented Dec 4, 2023

The fix is prepared and merged, it should appear on the master branch soon.

espressif-bot pushed a commit that referenced this issue Dec 8, 2023
@0xjakob
fix(esp_hw_support): Removed unused include directories from cmake
e3653aa 
* Closes #12700
espressif-bot pushed a commit that referenced this issue Dec 29, 2023
@0xjakob
fix(esp_hw_support): Removed unused include directories from cmake
900ee4e 
* Closes #12700
espressif-bot pushed a commit that referenced this issue Mar 1, 2024
@0xjakob
fix(esp_hw_support): Removed unused include directories from cmake
a66234b 
* Closes #12700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xjakob 0xjakob

Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xjakob @espressif-bot @Hairy-Lee