Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (esp_lcd): Don't assume panels are 16bit in VSYNC restart logic (IDFGH-11941) #13020

Closed

Conversation

bwhitman
Copy link
Contributor

I'm using RGB332 for my RGB panel. 8 bits a pixel.

I tried using CONFIG_LCD_RGB_RESTART_IN_VSYNC and found that it permanently corrupted (shifted) the screen, instead of fixing shifts.

I found that esp_lcd assumes a 16-bit display during the transmission logic and doesn't check fb_bits_per_pixel.

This PR is a fix for that error so that restarting in VSYNC doesn't permanently shift the screen.

I also fixed what I believe to be a smaller error in prefilling the "second" bounce buffer [1], was [0].

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 20, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix (esp_lcd): make sure fb bit depth is set before calling trans_link":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix for 8 bit panels":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello bwhitman, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 25fba0a

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 20, 2024
@github-actions github-actions bot changed the title Don't assume panels are 16bit in VSYNC restart logic Don't assume panels are 16bit in VSYNC restart logic (IDFGH-11941) Jan 20, 2024
@bwhitman bwhitman changed the title Don't assume panels are 16bit in VSYNC restart logic (IDFGH-11941) fix (esp_lcd): Don't assume panels are 16bit in VSYNC restart logic (IDFGH-11941) Jan 20, 2024
@suda-morris
Copy link
Collaborator

sha=25fba0a783701263bf1c576aac2c089fddddcc66

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Jan 22, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jan 22, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Jan 31, 2024
@suda-morris
Copy link
Collaborator

merged in commit ff840b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants