Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function vfs_spiffs_truncate to solve issue https://github.com/espressif/esp-idf/issues/2234 (IDFGH-2880) #2241

Closed
wants to merge 1 commit into from

Conversation

davctv
Copy link

@davctv davctv commented Jul 30, 2018

Hi,

I have added vfs_spiffs_truncate in esp_spiffs.c file.

I have also implemented the function in SPIFFS submodule. See here for the pull request to the repository

pellepl/spiffs#218

Thanks

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


davctv seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davctv
Copy link
Author

davctv commented Aug 2, 2018

Hi,

What happen if the submodule (spiffs) mantainer will not include the feature (or doesn't reply to PR) I propose in its repository?

In practice, the PR I propose here it is subjected to the PR on submodule.
Should I copy the spiffs module in components folder of my project and go ahead with it?

Thanks

@milamber-ls
Copy link

any progress on accepting this pull request?

@igrr
Copy link
Member

igrr commented Nov 25, 2018

Hi @milamber-ls we need the respective PR merged into SPIFFS repository first, as soon as this happens we can accept this PR.

@github-actions github-actions bot changed the title Added function vfs_spiffs_truncate to solve issue https://github.com/espressif/esp-idf/issues/2234 Added function vfs_spiffs_truncate to solve issue https://github.com/espressif/esp-idf/issues/2234 (IDFGH-2880) Mar 13, 2020
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
changed LORA_IO0 -> LORA_IRQ
added LORA_RST
added SS
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Mar 21, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution again and sorry for the very slow turnaround, changes merged with b95d2e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants