Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPS_CONFIG_INIT_DEFAULT(type) error (IDFGH-2538) #4625

Closed
wants to merge 1 commit into from

Conversation

DaveLacerte
Copy link

Same as PR #2869, but file is not in the same directory

Same as PR espressif#2869, but file is not in the same directory
@github-actions github-actions bot changed the title WPS_CONFIG_INIT_DEFAULT(type) error WPS_CONFIG_INIT_DEFAULT(type) error (IDFGH-2538) Jan 12, 2020
@sagb2015
Copy link
Contributor

@DaveLacerte: Thank you for your contribution and bringing up the issue. However, since the commit as is breaks C compilation, we will fixed it differently. We will update and close this PR once done.

@mahavirj
Copy link
Member

This has been addressed with first 9ebd2cc#diff-64c6b86dcd8c64c62ee1ef3380d4cefc and then 50588ff#diff-64c6b86dcd8c64c62ee1ef3380d4cefc. Fix is different than this PR to make it consistent across standards (C99 and C++).

Closing this PR.

@mahavirj mahavirj closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants