esp-netif: esp_netif_is_netif_up should also check netif_is_link_up (IDFGH-3171) #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise esp_netif_update_default_netif_lwip() may select wrong interface as default route. e.g. calling esp_netif_is_netif_up() for ppp interface before dialing up returns true without this patch then it's selected as the default route due to higher priority. Signed-off-by: Axel Lin <axel.lin@gmail.com>
github-actions
bot
changed the title
|
@AxelLin Thanks for your contribution. @david-cermak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise esp_netif_update_default_netif_lwip() may select wrong interface
as default route. e.g. calling esp_netif_is_netif_up() for ppp interface before
dialing up returns true without this patch then it's selected as the default
route due to higher priority.
Signed-off-by: Axel Lin axel.lin@gmail.com