upgrade ccache installed version to 4.6.2 (IDFGH-8160) #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- primary reason: 4.6.2 fixes errors if the user's home directory contains a space - alternative fix: the CCACHE_DIR env var can be set to something without a space in it, or set to TMP which properly escapes the home dir name - there may be other issues with spaces in filenames on builds in other parts of ESP-IDF, see espressif#8364 for more info tested locally on windows only, use at your own risk
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
There should be no issues with this, i've been using ccache 4.6.1 on Arch Linux for a while now and we have upped the CMake version for windows so it satisfies the minimum requirement as well. Let's merge this. @dobairoland |
|
sha=823ae5cf4550f6455ed761f496616361980fa4b1 |
espressif-bot
added
Status: In Progress
espressif-bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
- primary reason: 4.6.2 fixes errors if the user's home directory contains a space - alternative fix: the CCACHE_DIR env var can be set to something without a space in it, or set to TMP which properly escapes the home dir name - there may be other issues with spaces in filenames on builds in other parts of ESP-IDF, see #8364 for more info tested locally on windows only, use at your own risk Closes #9656
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested locally on windows only, use at your own risk