Added Functional Call To "erase_flash" In Minimal Launchpad #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwait-esp
requested changes
Oct 13, 2023
| @@ -69,6 +69,7 @@ async function downloadAndFlash() { | |||
| eraseAll: false, | |||
| compress: true, | |||
| }; | |||
| await esploader.erase_flash(); | |||
There was a problem hiding this comment.
can we have this called based on flag (eraseAll) ? if eraseAll is true then call erase_flash() before write_flash()
…es before new flash.
RushikeshPatange
force-pushed
the
minimal-launchpad/add_erase_flash_functionality_call
branch
from
88218ae
to
0972581
Compare
adwait-esp
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do ?
Test Link ?
https://rushikeshpatange.github.io/esp-launchpad/minimal-launchpad/