Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(minimal-launchpad): Handle Errors During The Fetching Of TOML File. #54

Conversation

RushikeshPatange
Copy link
Contributor

@RushikeshPatange RushikeshPatange commented Nov 27, 2023

What Does this MR Do ?

This pull request addresses an issue encountered in the minimal launchpad where errors during the fetching of the TOML file were not being adequately handled by showing proper error modal to the end user. These errors could be attributed to various factors, including network settings such as firewall configurations, VPN settings and more.

Test Link ?

You can see this fix through this link

@RushikeshPatange RushikeshPatange marked this pull request as ready for review November 27, 2023 12:35
Copy link
Collaborator

@adwait-esp adwait-esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwait-esp adwait-esp merged commit 0e9aab3 into espressif:main Nov 28, 2023
@RushikeshPatange RushikeshPatange deleted the minimal-launchpad/toml-fetch-error-handling branch January 30, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants