Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdns]: support allocating mDNS task with caps #756

Merged
merged 4 commits into from
Feb 10, 2025
Merged

[mdns]: support allocating mDNS task with caps #756

merged 4 commits into from
Feb 10, 2025

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak commented Feb 3, 2025 •
edited
Loading

@david-cermak david-cermak self-assigned this Feb 3, 2025
@david-cermak david-cermak mentioned this pull request Feb 3, 2025
Closed
6 tasks
@david-cermak
Copy link
Collaborator Author

@euripedesrocha @glmfe PTAL (esp. at the changes in components/mdns/mdns.c), maybe the same idea could be used in the current esp_websocket_client

zwx1995esp
zwx1995esp approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@zwx1995esp zwx1995esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me to solve these issues.

components/mdns/tests/test_afl_fuzz_host/esp32_mock.c Outdated Show resolved Hide resolved
components/mdns/tests/test_afl_fuzz_host/esp32_mock.h Outdated Show resolved Hide resolved
zwx1995esp and others added 4 commits February 10, 2025 11:18
@zwx1995esp @david-cermak
feat(mdns): support allocating mDNS task from SPIRAM
8fcad10
@david-cermak
fix(mdns): Use correct task delete function
eb4ab52
@david-cermak
ci(mdns): Fix mdns host test layers with static task creation
0690eba
@david-cermak
bump(mdns): 1.5.3 -> 1.6.0
cb061c9 
1.6.0
Features
- support allocating mDNS task from SPIRAM (8fcad10)
Bug Fixes
- Use correct task delete function (eb4ab52)
Updated
- ci(mdns): Fix mdns host test layers with static task creation (0690eba)
@david-cermak
Copy link
Collaborator Author

Thanks for helping me to solve these issues.

Thanks to you for addressing the problem in the first place 😄 and thanks for the review!

@david-cermak david-cermak merged commit ee2fbbb into espressif:master Feb 10, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwx1995esp zwx1995esp zwx1995esp approved these changes

@euripedesrocha euripedesrocha Awaiting requested review from euripedesrocha

@glmfe glmfe Awaiting requested review from glmfe

Assignees

@david-cermak david-cermak

Labels
mdns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow MDNS to allocate its stack from PSRAM. (IDFGH-14475)
2 participants
@david-cermak @zwx1995esp