[examples]: Test the SLIP netif example on target as well #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
fix/examples_target_tests
branch
4 times, most recently
from
61b18ba to
ea5fd6d
Compare
…etif by enabling PPP netif, so esp_netif knows that lwip's netif->state will be reserved for special netif info (slip) Closes espressif#759
david-cermak
force-pushed
the
fix/examples_target_tests
branch
from
ea5fd6d to
3e8d939
Compare
david-cermak
commented
Feb 12, 2025
| needs: build_all_examples | ||
| strategy: | ||
| matrix: | ||
| idf_ver: ["release-v5.3", "latest"] |
There was a problem hiding this comment.
run on v5.4, too
Suggested change
| idf_ver: ["release-v5.3", "latest"] | |
| idf_ver: ["release-v5.3", "release-v5.4", "latest"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
esp_netiffby default uses lwip'snetif->stateto store it's internal dataSolution
to address this properly we need to fix
esp_netifto either keep this reserved or add a Kconfig option to setNETIF_DATA-- will fix in IDF-12473here we provide a workaround to enable PPP netif to force
esp_netifnot to use the state fieldalso adds target test
Closes slip_custom_netif demo not working #759