Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdns]: Allow allocate memory with configured caps #764

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[mdns]: Allow allocate memory with configured caps #764

wants to merge 3 commits into from

Conversation

david-cermak
Copy link
Collaborator

Addresses IDF-11680: Add a config and a mechanism to support allocating memory from PSRAM for mDNS service.

@david-cermak david-cermak self-assigned this Feb 13, 2025
@david-cermak david-cermak force-pushed the feat/mdns_malloc_caps branch 3 times, most recently from e25de59 to 21737bb Compare February 13, 2025 13:58
@david-cermak
Copy link
Collaborator Author

@zwx1995esp PTAL, not sure how to approach coexistence of MDNS_TASK_MEMORY_ALLOC_FROM and MDNS_MEMORY_ALLOC_FROM or define a dependency between?
so far added them as two separate configs, but open for discussion.

zwx1995esp
zwx1995esp approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@zwx1995esp zwx1995esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot for such quick support.

components/mdns/CMakeLists.txt Outdated Show resolved Hide resolved
@zwx1995esp
Copy link
Collaborator

zwx1995esp commented Feb 14, 2025 •
edited
Loading

Not sure how to approach coexistence of MDNS_TASK_MEMORY_ALLOC_FROM and MDNS_MEMORY_ALLOC_FROM or define a dependency between? so far added them as two separate configs, but open for discussion.

Hi, David, I think we could keep both configurations for the user. If the task is created in internal memory, it can save some time during system task switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwx1995esp zwx1995esp zwx1995esp approved these changes

@euripedesrocha euripedesrocha Awaiting requested review from euripedesrocha

Assignees

@david-cermak david-cermak

Labels
mdns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-cermak @zwx1995esp