Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/support esp32h2 #102

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Feature/support esp32h2 #102

merged 4 commits into from
Jun 23, 2023

Conversation

adwait-esp
Copy link
Collaborator

  • Ported the changes from esptools.py for esp32h2 chipset.
  • Tested with H2 chipset and able to flash firmware image on h2 using the tool.

igrr
igrr approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one lint issue to fix so that pipeline passes.

brianignacio5
brianignacio5 requested changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small change

src/esploader.ts Outdated Show resolved Hide resolved
@adwait-esp
Copy link
Collaborator Author

Merging since the minor review comments are addressed and CI pipeline job has succeeded as well

@adwait-esp adwait-esp merged commit 66a109e into main Jun 23, 2023
@adwait-esp adwait-esp deleted the feature/support_esp32h2 branch June 26, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr approved these changes

@brianignacio5 brianignacio5 Awaiting requested review from brianignacio5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adwait-esp @igrr @brianignacio5