update buffer ref in esploader #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianignacio5
force-pushed
the
bugfix/rm-node-buffer-reference
branch
from
9ee60fb
to
331615e
Compare
|
Download the artifacts for this pull request: |
|
Thank you @brianignacio5 ! , for fixing this issue. I've successfully tested the fix for the newly added C2, on my local environment. |
|
I hadn't seen the introduction on Buffer because it was hidden inside the JSDoc API, which I assumed was only adding documentation. The buffer npm package is 2000 lines of JavaScript for a total of 26kB. Previously, esptool-js worked without it. Can you explain why we need to add this dependency? Size and impact of bundling buffer npm package (via bundlephobia) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using a node reference in esploader to Buffer class instead of the buffer npm module added.
This update should add reference to node_modules/buffer instead.
Fix #125