Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document passing arguments to main() #408

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Document passing arguments to main() #408

merged 2 commits into from
Apr 18, 2019

Conversation

marcelstoer
Copy link
Contributor

Addresses #406

Copy link
Contributor

@projectgus projectgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcelstoer ,

Thanks for sending this. I've been reluctant to document any of these approaches as I'm ashamed they're still necessary, but maybe this will spur me on to make a better Python API. :)

Hopefully someday soon this section can be deleted. Most likely this approach will remain compatible for all future versions though, as it's straightforward to keep the implementation like this.

README.md Outdated Show resolved Hide resolved
@marcelstoer
Copy link
Contributor Author

Most likely this approach will remain compatible for all future versions though

It's a relief to hear that! For my use case that "API" is perfect. However, I do understand that any other application that integrates esptool to use only individual functions needs something else.

@projectgus projectgus merged commit 6135095 into espressif:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants