Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_clang): fixed the clang to be installed as part of offline installer #284

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

alirana01
Copy link
Collaborator

@alirana01 alirana01 commented Oct 21, 2024

Description

esp-clang made part of offline installer required for the Eclipse

Related

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@alirana01 alirana01 self-assigned this Oct 21, 2024
@alirana01 alirana01 requested review from igrr and georgik October 21, 2024 10:57
@alirana01
Copy link
Collaborator Author

@igrr Can you please verify if the changes are correct for the esp-clang. I can then run the installer after merging it.

@alirana01 alirana01 merged commit 4025e06 into main Oct 23, 2024
4 checks passed
@alirana01 alirana01 deleted the IDFGH-13886 branch October 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant