[Xtensa] Fix Clang builtins include directory (LLVM-293) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes espressif#83 In short, it adjusts the include path logic to include the builtins directory as long as `-nostdinc` or `-nobuiltininc` isn't specified. Previously, the builtins directory would not be included if either the GCC installation wasn't found, or `-nostdlibinc` was specified (both of which aren't related to the builtins directory).
github-actions
bot
changed the title
|
@aykevl Thanks. Pulling this. Should be in the upcoming release. |
espressif-bot
added
Status: In Progress
espressif-bot
added
Status: In Review
Status: Done
aykevl
added a commit
to tinygo-org/tinygo
that referenced
this pull request
Feb 19, 2024
This workaround is no longer needed now that we've switched to LLVM 17 where this bug has been fixed upstream: espressif/llvm-project#84
deadprogram
pushed a commit
to tinygo-org/tinygo
that referenced
this pull request
Feb 19, 2024
This workaround is no longer needed now that we've switched to LLVM 17 where this bug has been fixed upstream: espressif/llvm-project#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #83.
In short, it adjusts the include path logic to include the builtins directory as long as
-nostdincor-nobuiltinincisn't specified.Previously, the builtins directory would not be included if either the GCC installation wasn't found, or
-nostdlibincwas specified (both of which aren't related to the builtins directory).I've tested this patch on TinyGo, but didn't test it otherwise.