feat(action): add dry_run option for upload validation (PACMAN-669) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suda-morris
force-pushed
the
feature/add_dry_run_option
branch
from
c8046bb
to
ade402c
Compare
github-actions
bot
changed the title
|
@suda-morris Thank you for this PR, yes it closes #10 too. LGTM, with one small comment |
kumekay
reviewed
Jul 17, 2023
|
@kumekay Not sure if this can be solved anyhow, but I ran into this problem enabling dry_run in idf-extra-components: espressif/idf-extra-components#220 (comment) |
|
@igrr I'll check on Monday whether we can allow it either without token, or with just any active token (not necessary valid for the namespace) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the --dry-run command line option to the Github Action.