Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Stop using VS Code pop-up notification for builds, flashing project messages. (VSC-1272) #1114

Closed
Seefer opened this issue Jan 16, 2024 · 8 comments · Fixed by #1118
Labels
Feature / Enhancement Request Request for Feature/ Enhancement

Comments

@Seefer
Copy link

Seefer commented Jan 16, 2024

This window pop-up obscures the terminal window output when I click on build or flash etc. I feel the proper place for messages of this nature should be sent to the terminal output windows instead of the GUI-based VS Code notification pop-up.

@Seefer Seefer added the Feature / Enhancement Request Request for Feature/ Enhancement label Jan 16, 2024
@github-actions github-actions bot changed the title [Feature Request]: Stop using VS Code pop-up notification for builds, flashing project messages. [Feature Request]: Stop using VS Code pop-up notification for builds, flashing project messages. (VSC-1272) Jan 16, 2024
@brianignacio5
Copy link
Collaborator

With the PR #1087 you can define how notifications are handle by this extension by using a ESP-IDF: Select output and notification mode command which allows to define a idf.notificationMode configuration setting to:

  1. Show task output and notifications
  2. Show only task output
  3. Show only notification
  4. Show nothing

@txf-
Copy link

txf- commented Jan 17, 2024

I would be nice to also have the option to suppress the switch from the terminal task to the ESP-IDF output ( when flashing for example)

@brianignacio5
Copy link
Collaborator

Does it happen when there is no errors or only when errors appear @txf- ?

@Seefer
Copy link
Author

Seefer commented Jan 19, 2024

It happens when simply building or flashing a project. The pop-up notification window seems redundant considering there's build and flash progress information being shown in the terminal window. I feel such messages are best output to the Terminal window and the notification windows is best used for situations where a problem has occurred, and user response is required.

image

@txf-
Copy link

txf- commented Jan 19, 2024

Does it happen when there is no errors or only when errors appear @txf- ?

It happens on success as well as failure.

One unfortunate consequence of this is that if I try to to use the build,flash and monitor option is that the jump messes up the serial monitor tab.

To get the monitor window to work correctly I need to flash flash separately, click again on the terminal tab and then open the monitor

@brianignacio5
Copy link
Collaborator

It happens when simply building or flashing a project. The pop-up notification window seems redundant considering there's build and flash progress information being shown in the terminal window. I feel such messages are best output to the Terminal window and the notification windows is best used for situations where a problem has occurred, and user response is required.

image

As I mentioned before, you can disable this pop-ups if you want with the mentioned command or configuration setting.

@txf-
Copy link

txf- commented Jan 23, 2024

As I mentioned before, you can disable this pop-ups if you want with the mentioned command or configuration setting.

I have the setting set to "Output", but this only hides the task "complete" notifications, it doesn't hide the "in-progress" such as the "Building Project" notification above.

Is there another setting that does this?

@brianignacio5
Copy link
Collaborator

I've added the PR #1118 to hide the progress notification based on idf.notificationMode. With this PR, Progress notification should be disabled when idf.notificationMode is different than All or Notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement Request Request for Feature/ Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants