Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/tarxz install #1118

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Bugfix/tarxz install #1118

merged 4 commits into from
Jan 26, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jan 25, 2024

Description

This PR add the following bug fixes

  • Fix tar.xz install issues in extension by removing tool version from install command.
  • Add idf.notificationMode to vscode.window.withProgress({},()=>{}) functions to show progress in status bar when idf.notificationMode is set to All or Notification.
  • Add ESP32-P4 to extension keywords in package.json
  • Update tasks.json for debug adapter task.

Fixes #1114
Fixes #1113
Fixes #1063

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Try to configure extension with ESP-IDF: Configure ESP-IDF extension for ESP-IDF v5.2 in Linux. GCC Tools should be installed correctly and building any ESP-IDF v5.2 example Project should work.
  2. Execute ESP-IDF: Build your project with idf.notificationMode set to All or Notification. The progress notification should be shown. Change idf.notificationMode to a different value like Output. The progress notification should not be shown.
  3. Observe results.
  • Expected behaviour:

For ESP-IDF v5.2 the GCC toolchain should be installed and building example esp-idf project should work

Progress notification should be able to enable and disable based on idf.notificationMode configuration setting.

  • Expected output:

How has this been tested?

Manual testing explained above.

Test Configuration:

  • ESP-IDF Version: 5.2
  • OS (Windows,Linux and macOS): Linux

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Jan 25, 2024
@brianignacio5 brianignacio5 added this to the v1.7.0 milestone Jan 25, 2024
@brianignacio5 brianignacio5 self-assigned this Jan 25, 2024
Copy link

github-actions bot commented Jan 25, 2024

Download the artifacts for this pull request:

@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Jan 26, 2024

@brianignacio5 hi !

Tested:
OS - Ubuntu 20.04
ESP-IDF: v5.2

Able to: download v5.2 version / configure ESP-IDF extension without errors / create-build-flash-monitor project 👍
Also checked notifications. Do not see building progress notifications with "Output" mode selected

LGTM 👍

@brianignacio5 brianignacio5 merged commit badebbe into master Jan 26, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/tarxz-install branch January 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
2 participants