Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the following bug fixes
vscode.window.withProgress({},()=>{})
functions to show progress in status bar when idf.notificationMode is set toAll
orNotification
.Fixes #1114
Fixes #1113
Fixes #1063
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Configure ESP-IDF extension
for ESP-IDF v5.2 in Linux. GCC Tools should be installed correctly and building any ESP-IDF v5.2 example Project should work.ESP-IDF: Build your project
withidf.notificationMode
set toAll
orNotification
. The progress notification should be shown. Changeidf.notificationMode
to a different value likeOutput
. The progress notification should not be shown.For ESP-IDF v5.2 the GCC toolchain should be installed and building example esp-idf project should work
Progress notification should be able to enable and disable based on
idf.notificationMode
configuration setting.How has this been tested?
Manual testing explained above.
Test Configuration:
Checklist