-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/migrate vue3 #1035
Enhance/migrate vue3 #1035
Conversation
29efaad
to
86ab91b
Compare
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments for small left overs. Also, the things found by code scanner should be addressed before merging
Pull request has been marked as |
cdef3ad
to
9b53a82
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@brianignacio5 hi! |
This comment was marked as resolved.
This comment was marked as resolved.
Please show all hyper links text in the blue color. Example - |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Fixed all commented issues @AndriiFilippov PTAL when you can |
This comment was marked as resolved.
This comment was marked as resolved.
dec74ad
to
01cc9d7
Compare
@brianignacio5 hi ! Tested under: LGTM 👍 |
Description
Update web views from Vue 2 and vuex to Vue 3 and Pinia because vue 2 support will be dropped the end of this year.
Fix #1051 Added search for
ESP-IDF: Show Examples
commandType of change
Steps to test this pull request
This PR is very big and many features need to be tested. Basically all web views under
src/views
CMakeLists.txt
file and selectESP-IDF: CMakeLists.txt editor
command. If the file is root directory choose ProjectProject CMakeLists.txt
otherwise chooseComponent CMakeLists.txt
. Use UI to modify values and see changes on CMakeLists.txt. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.ESP-IDF: Show examples projects
. Choose example, check rendered markdown view, create project. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.ESP-IDF: SDK Configuration editor (menuconfig)
command. Modify different kind of values like number, string, hex, checkbox, select dropdown. Check the ESP-IDF output for any error. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.ESP-IDF: New Project
command. Modify all options, Try to add a local component, choose template and create a project. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.nvs_data.csv
and selectESP-IDF: Open NVS Partition editor
. add, Modify or remove values and types and click the different action buttons. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.partitions_example.csv
and selectESP-IDF: Open Partition table editor UI
. add, Modify or remove values and types and click the different action buttons. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.Developer: Open web view Developer tools
and see if there is any error in the console.ESP-IDF: Configure ESP-IDF extension
command and run the 3 kinds of setup from UI: Express Advanced and use existing setup. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.Developer: Open web view Developer tools
and see if there is any error in the console.Developer: Open web view Developer tools
and see if there is any error in the console.ESP-IDF: Welcome
to open the extension welcome page and test all links and buttons. RunDeveloper: Open web view Developer tools
and see if there is any error in the console.Expected behaviour:
Expected output:
How has this been tested?
Manual testing of each view
Test Configuration:
Dependent components impacted by this PR:
Checklist