update dockerfile devcontainer #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
brianignacio5
force-pushed
the
bugfix/dockerfile-template
branch
from
b243111 to
ea89704
Compare
radurentea
approved these changes
Jan 17, 2024
brianignacio5
force-pushed
the
bugfix/dockerfile-template
branch
2 times, most recently
from
cf81ca9 to
418f25a
Compare
|
@brianignacio5 hi ! Tested: Do see Python updates. LGTM 👍 |
AndriiFilippov
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Dockerfile and devcontainer.json to latest IDF and python version.
Add Python Lib directory to Path in python env install.
Fixes #1100
Fixes #1101
Fixes #1106
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Expected behaviour:
Expected output:
How has this been tested?
Manual test of setup wizard on Windows.
Test Configuration:
Checklist