Fix custom tasks #1238
Merged
Fix custom tasks #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modifications for white spaces were not needed here.
|
Download the artifacts for this pull request: |
|
Hi @AndriiFilippov, PTAL |
|
Pull request has been marked as |
|
@radurentea hi ! Tested under: able to build, do see preBuild and postBuild tasks executed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for the custom tasks
Fixes #1232
Fix #1244
Type of change
Steps to test this pull request
"idf.preBuildTask": "echo 'Pre-build task executed!'"In the Pre-build tab, you should see the following:
How has this been tested?
As described above, for all shells with and without white spaces inside ESP-IDF's path and project's path
Test Configuration:
Checklist