Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/walkthrough documentation #1354

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

radurentea
Copy link
Collaborator

Description

  • Modified Basic Walkthrough "Configure the ESP-IDF VS Code Extension" step. (post-installation part)
  • Collapse all menus in ESP-IDF: Explorer, except "Commands"

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Make sure to use a new VS Code installation so that the visibility of the menus are on cached.

How has this been tested?

As explained above

Test Configuration:

  • ESP-IDF Version: 5.3.1
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the "visibility": "collapsed" part. Much needed !

Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@radurentea radurentea merged commit 7e4b592 into master Nov 29, 2024
6 checks passed
radurentea added a commit that referenced this pull request Nov 29, 2024
* Update post-installation step

* Collapse all menus except commands
brianignacio5 added a commit that referenced this pull request Dec 10, 2024
* Add changelog for 1.9.0 release

* add flash monitor redirect in buildFlashMonitor command

* add validation for getEnvVarsFromIdfTools

* add IDF_PYTHON_ENV_PATH validation

* Bugfix/walkthrough documentation (#1354)

* Update post-installation step

* Collapse all menus except commands

* update activation init check settings

remove extension settings await

use showOnBoarding to show welcome page

increase timeout of notifications

increase notification timeout

disable show info message on check extension setting

fix lint

rm console log

* Use major + minor versions, remove patch version (#1360)

* add cmd pwsh idf py autocomplete

* add scripts to prettier ignore

* update changelog

* move scripts to root folder

* add bypass execution policy for powershell windows

---------

Co-authored-by: Radu <radu.rentea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants