Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select openOCD board command #286

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Select openOCD board command #286

merged 5 commits into from
Jan 15, 2021

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jan 8, 2021 •
edited
Loading

Add command Select OpenOCD Board Configuration to choose any of the boards defined in OpenOCD-esp32 Scripts's esp-config.json

@brianignacio5 brianignacio5 requested a review from pwmb January 11, 2021 11:39
@brianignacio5 brianignacio5 self-assigned this Jan 11, 2021
@brianignacio5 brianignacio5 added the Feature A new feature label Jan 11, 2021
@brianignacio5 brianignacio5 marked this pull request as ready for review January 11, 2021 11:50
@brianignacio5 brianignacio5 changed the title openocd board conf cmd Select openOCD board command Jan 11, 2021
@pwmb
Copy link
Contributor

pwmb commented Jan 14, 2021

@brianignacio5 PTAL 634d146

pwmb
pwmb approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@pwmb pwmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

Left one suggestion

src/extension.ts Show resolved Hide resolved
@brianignacio5
Copy link
Collaborator Author

@brianignacio5 PTAL 634d146

LGTM !

@pwmb pwmb self-requested a review January 15, 2021 07:42
pwmb
pwmb approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@pwmb pwmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit d767d6a into master Jan 15, 2021
@brianignacio5 brianignacio5 added this to the v0.6.1 milestone Jan 19, 2021
@brianignacio5 brianignacio5 deleted the feature/openocd-boards branch May 8, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwmb pwmb pwmb approved these changes

Assignees

@brianignacio5 brianignacio5

Labels
Feature A new feature
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@brianignacio5 @pwmb