Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple IDF versions in setup wizard #898

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Feb 24, 2023

Description

Expand use existing setup to load existing ESP-IDF setups in the user systems.

Every time the user saves a new ESP-IDF path it will saved in the extension global state and appear later in the Existing Setup and also uses IDF_TOOLS_PATH to load esp-idf.json for existing ESP-IDF setups.

Fixes #832

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Test changing multiple ESP-IDF versions using manual testing of wizard.

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Feb 24, 2023
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Download the artifacts for this pull request:

fix advanced setup

fix tests

fix doctor test

fix ui test

fix doctor test

fix ui test
@brianignacio5 brianignacio5 force-pushed the feature/change-idf-versions-in-setup branch from 28363b7 to 79172c6 Compare February 28, 2023 08:58
@brianignacio5 brianignacio5 marked this pull request as ready for review February 28, 2023 11:29
@brianignacio5 brianignacio5 merged commit df9ad8a into master Feb 28, 2023
@brianignacio5 brianignacio5 deleted the feature/change-idf-versions-in-setup branch February 28, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: make is easier to use multiple ESP-IDF versions side by side (VSC-1001)
1 participant