Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update non root container dockerfile #910

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

brianignacio5
Copy link
Collaborator

Description

Define non root user in Dockerfile and update template devcontainer.json to latest schema for settings and extensions.

Fixes #883

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Manual testing opening a project in a docker container.

Test Configuration:

  • ESP-IDF Version: 4.4.2
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the 1.6.1 milestone Mar 17, 2023
@brianignacio5 brianignacio5 self-assigned this Mar 17, 2023
@github-actions
Copy link

github-actions bot commented Mar 17, 2023

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jimmyw jimmyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added tip to re-use same paths inside and outside, this really makes this solution seamless to me.

templates/.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
templates/.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@brianignacio5 brianignacio5 merged commit e444eda into master Apr 3, 2023
@brianignacio5 brianignacio5 deleted the enhance/non-root-docker-template branch April 3, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non root containers (VSC-1042)
3 participants