Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove virtualenv install from extension #956

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

Description

Remove virtualenv install from extension setup process.

Fixes #919
Fix #949

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Click on "Configure ESP-IDF extension" command.
  2. Execute setup process using Python 3.11.
  3. Observe results. Install setup should work.

How has this been tested?

Manual test of setup install

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Apr 28, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit e8da6fb into master May 4, 2023
@brianignacio5 brianignacio5 deleted the bugfix/pep668 branch May 4, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants