Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault while removing virtual site #3286

Closed
pstaerk opened this issue Oct 31, 2019 · 1 comment · Fixed by #3288
Closed

Segfault while removing virtual site #3286

pstaerk opened this issue Oct 31, 2019 · 1 comment · Fixed by #3288
Assignees

Comments

@pstaerk
Copy link
Contributor

pstaerk commented Oct 31, 2019

import espressomd
from espressomd.virtual_sites import VirtualSitesRelative

box_l = 10

system = espressomd.System(box_l=[box_l,box_l,box_l])
system.virtual_sites = VirtualSitesRelative(have_velocity=True, 
        have_quaternion=False)

skin = .6
dt = .001
system.time_step = dt
system.cell_system.skin = skin

p0 = system.part.add(type=1, pos=[0.0316-1,3.7522-1,6.4854-1])
p0.v = [1,1,1]
p2 = system.part.add(type=2, pos=[0.0300-1,3.7528-1,6.4855-1])

p2.vs_auto_relate_to(0)
system.integrator.run(971)
p2.remove()
@fweik
Copy link
Contributor

fweik commented Oct 31, 2019

Thank you for reporting this issue. It's not actually related to virtual sites, but was a general bug in the particle removal code that you happened to trigger. This is fixed in #3288.

bors bot added a commit that referenced this issue Oct 31, 2019
3288: core: Simplify particle removal r=fweik a=fweik

Fixes #3286.

Description of changes:
 - Simplify particle removal by doing one linear pass over all particles
   instead using index


Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors bors bot closed this as completed in e8f4035 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants