Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of the _system construct. #1294

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Getting rid of the _system construct. #1294

merged 2 commits into from
Aug 8, 2017

Conversation

KaiSzuttor
Copy link
Member

Fixes #1284

Description of changes:

  • Removed the python module 'system' and modified the cython class _system, now named system appropriately

hmenke
hmenke approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@hmenke hmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we got rid of the stupid @highlander but there is still a singleton for the system class. Is there a reason we can't have several instances in one script?

@KaiSzuttor
Copy link
Member Author

There is still a lot of core code that would cause trouble if we'd allow multi instances of system.
I.e. i think we cant until everything is object oriented in the core.

@fweik fweik merged commit 6adebdb into espressomd:python Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke approved these changes

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaiSzuttor @fweik @hmenke