Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crosslink, salt and further unused code from polymer.?pp #1793

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

RudolfWeeber
Copy link
Contributor

Fixes #

Description of changes:

PR Checklist

  • Tests?
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #1793 into python will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           python   #1793     +/-   ##
========================================
+ Coverage      58%     59%     +1%     
========================================
  Files         397     417     +20     
  Lines       27372   29043   +1671     
========================================
+ Hits        15978   17248   +1270     
- Misses      11394   11795    +401
Impacted Files Coverage Δ
src/core/polymer.cpp 27% <ø> (+11%) ⬆️
src/core/EspressoSystemInterface.hpp 41% <0%> (-22%) ⬇️
src/core/lees_edwards.cpp 81% <0%> (-19%) ⬇️
src/core/lb.cpp 63% <0%> (-7%) ⬇️
src/core/grid.hpp 81% <0%> (-7%) ⬇️
src/core/thermostat.hpp 93% <0%> (-5%) ⬇️
src/core/reaction_field.hpp 11% <0%> (-3%) ⬇️
src/core/iccp3m.cpp 73% <0%> (-3%) ⬇️
src/core/constraints/ShapeBasedConstraint.cpp 30% <0%> (-2%) ⬇️
src/core/integrate.cpp 73% <0%> (-2%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a908c34...b3a2f03. Read the comment docs.

@fweik fweik merged commit 9df592a into espressomd:python Jan 30, 2018
ashreyaj pushed a commit to ashreyaj/espresso that referenced this pull request Aug 9, 2018
Remove crosslink, salt and further unused code from polymer.?pp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants