-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testsuite: Check planar shear profile of LB #2263
Conversation
Sooo... lets rewrite LBGPU? 😒 |
Well I don't know. Disable the test for GPU an tell nobody about it? |
testsuite/lb_shear.py
Outdated
---------- | ||
x : :obj:`float` | ||
Position from the left plane. | ||
nu : :obj:`float` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add doc for t
testsuite/lb_shear.py
Outdated
h : :obj:`float` | ||
Distance between the plates. | ||
k_max: :obj:`int` | ||
Maximum considered wave number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add doc for returned value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sth. like
Returns
———-
:obj:`double` : Analytical velocity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. But there is not return type as this is python. Depends on what you put in. That's also true for the other ones. In the test it is used with numpy arrays, but it would also work with floats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have 5. of https://numpydoc.readthedocs.io/en/latest/format.html#docstring-standard in mind
testsuite/lb_shear.py
Outdated
Shear rate. | ||
h : :obj:`float` | ||
Distance between the plates. | ||
k_max: :obj:`int` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after k_max
testsuite: Check planar shear profile of LB
No description provided.