aovid error with widom insertion. exclusion radius should not have any effect here #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2294 +/- ##
=======================================
+ Coverage 71% 71% +<1%
=======================================
Files 380 380
Lines 18938 18936 -2
=======================================
+ Hits 13586 13588 +2
+ Misses 5352 5348 -4
Continue to review full report at Codecov.
|
fweik
reviewed
Oct 4, 2018
src/core/reaction_ensemble.cpp
Outdated
| E_pot_new = std::numeric_limits<double>::max(); | ||
| else | ||
| E_pot_new = calculate_current_potential_energy_of_system(); | ||
| double E_pot_new= calculate_current_potential_energy_of_system(); |
|
LB test fails because it does not science the desired accuracy. Untouched. |
|
This fix workes.
Am Sa., 3. Nov. 2018, 06:20 hat Kai Szuttor <notifications@github.com>
geschrieben:
… @jonaslandsgesell <https://github.com/jonaslandsgesell>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2294 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE8wPb5K4XwbjRBj1xn0uj-2aGLInNfOks5urSeVgaJpZM4XIrab>
.
|
|
style check failed |
|
@jonaslandsgesell what is the status on this? |
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Nov 26, 2018
aovid error with widom insertion. exclusion radius should not have any effect here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.