Fix Simple Pore #2379
Merged
Fix Simple Pore #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2379 +/- ##
=======================================
+ Coverage 72% 72% +<1%
=======================================
Files 397 397
Lines 18773 18778 +5
=======================================
+ Hits 13580 13590 +10
+ Misses 5193 5188 -5
Continue to review full report at Codecov.
|
Draw a random velocity according to the Maxwell-Boltzmann distribution. Fixes espressomd#1770
Support neutral charges in the reaction ensemble
use correct Maxwell-Boltzmann velocity distribution in reaction ensemble
|
This needs a test. |
fweik
approved these changes
Nov 30, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Dec 6, 2018
Fix Simple Pore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes simple pore shape, in particular distance calculation and if a point is inside or outside the shape.