Electrostatic pressure consistency #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSzuttor
reviewed
Dec 7, 2018
| import espressomd | ||
| from espressomd import electrostatics | ||
| import tests_common | ||
| import numpy.testing as npt |
There was a problem hiding this comment.
please move the external imports to the ones above
KaiSzuttor
reviewed
Dec 7, 2018
| num_samples = 100 | ||
| pressure_via_volume_scaling = np.nan | ||
| for i in range(num_samples): | ||
| self.system.integrator.run(100) |
There was a problem hiding this comment.
maybe we can use less integration steps?
There was a problem hiding this comment.
this will have an impact on the accuracy. it is a statistical equivalence of the pressures only.
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| print("Features: ", espressomd.features()) |
There was a problem hiding this comment.
please remove print statement
|
|
||
| import espressomd | ||
| from espressomd import electrostatics | ||
| import tests_common |
There was a problem hiding this comment.
you are not using tests_common
KaiSzuttor
reviewed
Dec 7, 2018
| def test_p3m_pressure(self): | ||
| pressures_via_virial = [] | ||
| pressures_via_volume_scaling = [] | ||
| p3m = electrostatics.P3M(prefactor=2.0, accuracy=1e-3) |
There was a problem hiding this comment.
Maybe it's a good idea to also check the GPU version?
|
GPU P3M does not support energy calculations. That would be a good idea -
but not possible without energy calculation.
Am Fr., 7. Dez. 2018, 18:39 hat Kai Szuttor <notifications@github.com>
geschrieben:
… ***@***.**** commented on this pull request.
------------------------------
In testsuite/python/p3m_electrostatic_pressure.py
<#2409 (comment)>:
> + system.change_volume_and_rescale_particles(old_box_lengths[0], "xyz")
+ system.integrator.run(0)
+ DeltaEpot = Epot_new - Epot_old
+ particle_number = len(system.part[:].id)
+ current_value = (new_volume / old_volume)**particle_number * \
+ np.exp(-DeltaEpot / kbT)
+ list_of_previous_values.append(current_value)
+ average_value = np.mean(list_of_previous_values)
+
+ pressure = kbT / dV * np.log(average_value)
+ return pressure
+
+ def test_p3m_pressure(self):
+ pressures_via_virial = []
+ pressures_via_volume_scaling = []
+ p3m = electrostatics.P3M(prefactor=2.0, accuracy=1e-3)
Maybe it's a good idea to also check the GPU version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2409 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE8wPW61Qk_3h3FPHFMRHlNyk9Qf6c0mks5u2qe1gaJpZM4ZI1hf>
.
|
|
|
…landsgesell/espresso into electrostatic_pressure_consistency
|
Please squash the commits as you merge. |
Codecov Report
@@ Coverage Diff @@
## python #2409 +/- ##
======================================
Coverage 72% 72%
======================================
Files 396 396
Lines 18631 18631
======================================
Hits 13454 13454
Misses 5177 5177Continue to review full report at Codecov.
|
KaiSzuttor
reviewed
Dec 10, 2018
KaiSzuttor
approved these changes
Dec 10, 2018
…electrostatic_pressure_consistency
…electrostatic_pressure_consistency
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Jan 7, 2019
* add check * add check * patch * imports * up * Update p3m_electrostatic_pressure.py * format * Update p3m_electrostatic_pressure.py * apply patch * exchange assert code * docstring for test * apply patch * reformulate comparison * year * patch * revert to np testing * changed comparison to maximal 2 percent deviation * changed comparison to maximal 2 percent deviation * patch * empty * add tune skin * add warmup * patch * refactor pressure calculation in small python class * patch * new style class * add LJ to required features * patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2405