Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix GSL linking. #2429

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

KaiSzuttor
Copy link
Member

fixes build with gsl.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #2429 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2429    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         393     393            
  Lines       18483   18483            
=======================================
+ Hits        13411   13434    +23     
+ Misses       5072    5049    -23
Impacted Files Coverage Δ
src/core/layered.cpp 78% <0%> (ø) ⬆️
src/core/domain_decomposition.cpp 95% <0%> (+4%) ⬆️
src/core/lattice.cpp 89% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71481b1...aa0a3c4. Read the comment docs.

@fweik fweik merged commit 9f9a125 into espressomd:python Jan 7, 2019
@KaiSzuttor
Copy link
Member Author

@RudolfWeeber a similar fix should be applied to the 4.0.1 release

RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Jan 7, 2019
@KaiSzuttor KaiSzuttor deleted the fix_gsl_build branch April 2, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants