Observable template

[jngrad]

sorry

patches #2621

[fweik]

Why did the old code build?

[jngrad]

Not sure, there isn't any T class/struct anywhere; you can even add using C = T; or using D = UWX; in /src/script_interface/observables/CylindricalProfileObservable.hpp and it will still compile just file. But it won't work in /src/core/. Maybe the -Wall flag in CMake is not inherited by the target that compiles the Python bindings?

[codecov]

Codecov Report

Merging #2623 into python will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           python   #2623   +/-   ##
======================================
  Coverage      78%     78%           
======================================
  Files         495     495           
  Lines       27366   27366           
======================================
  Hits        21519   21519           
  Misses       5847    5847

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad7bc4...6dc346e. Read the comment docs.

[jngrad]

File /src/script_interface/observables/CylindricalProfileObservable.hpp needs to be removed. It is not included anywhere, and the classes declared in it are actually already declared in /src/script_interface/observables/initialize.cpp and properly unit tested.