Simplify bonded/non-bonded IAs code #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3032 +/- ##
======================================
- Coverage 82% 82% -1%
======================================
Files 529 529
Lines 26793 26790 -3
======================================
- Hits 22099 22095 -4
- Misses 4694 4695 +1
Continue to review full report at Codecov.
|
fweik
approved these changes
Jul 31, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2019
3032: Simplify bonded/non-bonded IAs code r=fweik a=jngrad Description of changes: - use utils/math functions and Vector3d-specific functions to simplify the code logic - use `auto const` to avoid mistakes - fix copy-paste errors in Doxygen documentation Required for #2502, more Vector3d refactoring will take place in subsequent PRs. Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
auto constto avoid mistakesRequired for #2502, more Vector3d refactoring will take place in subsequent PRs.