Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce usage of local_cells #3065

Merged
merged 14 commits into from
Aug 9, 2019
Merged

Reduce usage of local_cells #3065

merged 14 commits into from
Aug 9, 2019

Conversation

reinaual
Copy link
Contributor

@reinaual reinaual commented Aug 8, 2019

Fixes part of #2899

@codecov
Copy link

codecov bot commented Aug 8, 2019 •
edited
Loading

Codecov Report

Merging #3065 into python will decrease coverage by <1%.
The diff coverage is 73%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3065   +/-   ##
======================================
- Coverage      82%     82%   -1%     
======================================
  Files         529     529           
  Lines       26076   26098   +22     
======================================
+ Hits        21439   21451   +12     
- Misses       4637    4647   +10
Impacted Files Coverage Δ
.../electrostatics_magnetostatics/mdlc_correction.hpp 100% <ø> (ø) ⬆️
...core/electrostatics_magnetostatics/p3m-dipolar.hpp 100% <ø> (ø) ⬆️
...ore/grid_based_algorithms/lb_particle_coupling.hpp 100% <ø> (ø) ⬆️
src/core/electrostatics_magnetostatics/p3m.hpp 100% <ø> (ø) ⬆️
src/core/electrostatics_magnetostatics/icc.hpp 100% <ø> (ø) ⬆️
src/core/io/writer/h5md_core.hpp 53% <ø> (ø) ⬆️
src/core/cells.cpp 90% <100%> (-1%) ⬇️
src/core/io/writer/h5md_core.cpp 89% <100%> (ø) ⬆️
src/core/forces.hpp 100% <100%> (ø) ⬆️
src/core/electrostatics_magnetostatics/icc.cpp 84% <100%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c6083...520ea2f. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Aug 9, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 9, 2019

Merge conflict (retrying...)

@jngrad
Copy link
Member

jngrad commented Aug 9, 2019 •
edited
Loading

bors r-
(I'll resolve the merge conflict here, it seems to be just a newline character)

@jngrad
Copy link
Member

jngrad commented Aug 9, 2019

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 9, 2019

Canceled

@jngrad
Copy link
Member

jngrad commented Aug 9, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 9, 2019
@bors @reinaual @jngrad
Merge #3065
74b63f5 
3065: Reduce usage of local_cells r=jngrad a=reinaual

Fixes part of #2899


Co-authored-by: Alexander Reinauer <st144434@stud.uni-stuttgart.de>
Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Aug 9, 2019

Build succeeded

@bors bors bot merged commit 520ea2f into espressomd:python Aug 9, 2019
@reinaual reinaual deleted the local_cells2 branch October 1, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinaual @jngrad