Icc vs energy fix #3128
Merged
Icc vs energy fix #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but the tests say otherwise. |
Codecov Report
@@ Coverage Diff @@
## python #3128 +/- ##
=======================================
+ Coverage 83% 83% +<1%
=======================================
Files 530 530
Lines 26141 26150 +9
=======================================
+ Hits 21949 21961 +12
+ Misses 4192 4189 -3
Continue to review full report at Codecov.
|
bors bot
added a commit
that referenced
this pull request
Sep 9, 2019
3128: Icc vs energy fix r=RudolfWeeber a=itischler Fixes #3079 Description of changes: - changes in virtual sites and icc are now applied in on_observable_calc PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: itischler <ingo.tischler@gmx.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3079
Description of changes:
PR Checklist