-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external force density in first integration step #3144
Conversation
Codecov Report
@@ Coverage Diff @@
## python #3144 +/- ##
========================================
+ Coverage 84% 84% +<1%
========================================
Files 526 523 -3
Lines 26091 24881 -1210
========================================
- Hits 22138 21142 -996
+ Misses 3953 3739 -214
Continue to review full report at Codecov.
|
ready for review @RudolfWeeber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call
lbfields = lb_get_initialized_fields(lbpar, lblattice);
might result in the fields array to be allocated twice (once the previous value of fields, once the one instanced in the funciton.).
Probably better pass fields as a reference to the funciton.
Also, please add doxgen for teh funciotn since it has some non-obvious logic.
There is a lot of unrelated formatting in there. Please check that your autopep8 args and version match the one in the CI.
sorry, I forgot to enable some formatting flags... the version is the same as in the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
3144: external force density in first integration step r=RudolfWeeber a=KaiSzuttor Fixes #2875 Description of changes: - initialize the force density member with the external force density set by the user - if node velocity is set from the interface, the force density on this node is reset Co-authored-by: Kai Szuttor <kai@icp.uni-stuttgart.de> Co-authored-by: RudolfWeeber <weeber@icp.uni-stuttgart.de>
Build succeeded |
Fixes #2875
Description of changes: