Disable ELC for non-neutral systems with dielectric contrast #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
approved these changes
Sep 17, 2019
|
Thanks! You can add a line in the 4.1 release notes to document this change |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
3178: Disable ELC for non-neutral systems with dielectric contrast r=jngrad a=reinaual Disables the parameter combination in ELC causing #3001 3179: local_cells.particles() leftovers in MMM2D r=jngrad a=reinaual Co-authored-by: Alexander Reinauer <st144434@stud.uni-stuttgart.de>
Build succeeded |
Codecov Report
@@ Coverage Diff @@
## python #3178 +/- ##
======================================
- Coverage 85% 85% -1%
======================================
Files 526 526
Lines 26033 26046 +13
======================================
- Hits 22169 22164 -5
- Misses 3864 3882 +18
Continue to review full report at Codecov.
|
|
why do we keep testsuite/python/elc_vs_mmm2d_nonneutral.py? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the parameter combination in ELC causing #3001