-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametric weight function for DPD.... #3570
Conversation
Codecov Report
@@ Coverage Diff @@
## python #3570 +/- ##
======================================
- Coverage 88% 88% -1%
======================================
Files 524 524
Lines 23598 23598
======================================
- Hits 20772 20770 -2
- Misses 2826 2828 +2
Continue to review full report at Codecov.
|
|
yeah 1- x^0 is zero and the weight function is totally gone. Couldn't find a way to simplify it even more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks good to me, but you should add a bit more documentation. In the main docs of the
DPD interaction (6.1.14. DPD interaction in doc/sphinx/inter_non-bonded.rst
) you should
include the exponent factor into the formulas for the weight function and maybe add a literature
reference to the paper that describes the physical effect of changing the parameter.
LGTM, thank you for your contribution. I'll take it from here. |
... with a parabolic weight function
Description of changes:
DPDInteraction
for the exponent for the weight function