-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update espresso-ci scripts #3613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo tmp changes
I should have seen that coming: we need a chained if-else to test all possible names for clang-format and we need to use |
The GitHub token must now be part of the headers. The old syntax is deprecated: https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Now that the secret GitHub token is no longer part of the URL, it's safe to raise an exception that prints the URL with the error code.
7a8bf0a
to
5636ee0
Compare
Codecov Report
@@ Coverage Diff @@
## python #3613 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 525 525
Lines 23398 23398
======================================
- Hits 20583 20582 -1
- Misses 2815 2816 +1
Continue to review full report at Codecov.
|
I already approved |
Yes, but there were new changes after, did you look at them? |
Also, since when is the approval not removed if new changes are pushed? |
I realized that behavior several weeks ago and found it strange too, but did not question it. The "marked this pull request as ready for review 11 hours ago" message it posted automatically when removing the draft status of a PR. I did not add the |
It's a setting in the branch protection rules. Not sure if this conflicts with kodiak's merge |
Description of changes: