Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI images #3642

Merged
merged 10 commits into from
Apr 9, 2020
Merged

Update CI images #3642

merged 10 commits into from
Apr 9, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Apr 8, 2020

Description of changes:

  • update image tags for non-ubuntu CI jobs
  • update name of image for Travis-CI
  • add manual jobs for latest images
  • update docs deployment

@jngrad jngrad added the DevOps label Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #3642 into python will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3642    +/-   ##
=======================================
  Coverage      88%     88%            
=======================================
  Files         525     523     -2     
  Lines       23031   22446   -585     
=======================================
- Hits        20312   19851   -461     
+ Misses       2719    2595   -124
Impacted Files Coverage Δ
src/script_interface/shapes/Slitpore.hpp 80% <0%> (-11%) ⬇️
src/utils/tests/Factory_test.cpp 84% <0%> (-3%) ⬇️
src/core/BoxGeometry.hpp 85% <0%> (-2%) ⬇️
...interface/constraints/HomogeneousMagneticField.hpp 81% <0%> (-2%) ⬇️
src/core/nonbonded_interactions/gay_berne.hpp 97% <0%> (-2%) ⬇️
src/core/thermostat.hpp 90% <0%> (-2%) ⬇️
src/core/reaction_ensemble.hpp 77% <0%> (-1%) ⬇️
src/core/constraints/ShapeBasedConstraint.cpp 86% <0%> (-1%) ⬇️
src/core/immersed_boundary/ImmersedBoundaries.cpp 25% <0%> (-1%) ⬇️
src/script_interface/get_value.hpp 86% <0%> (-1%) ⬇️
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbae77e...3ba435d. Read the comment docs.

jngrad added 6 commits April 8, 2020 23:43
@jngrad
Use Ubuntu 18.04 image in Travis-CI
0eadc12 
The Travis image is nearly identical to the Ubuntu 18.04 image.
They are both available on DockerHub. Using image Ubuntu 18.04
in both GitLab-CI and Travis-CI reduces dockerfile duplication.
@jngrad
Deploy docs with Ubuntu 20.04
a4ed00b
@jngrad
Simplify ssh-agent command
03e3528 
openssh is now always installed.
@jngrad
Fix deprecated syntax
db70b72 
Deprecated since Sphinx 1.8. Raises a warning since Sphinx 3.0.
@jngrad
Fix "duplicate object description" issues
d85dbda 
These issues raise errors in Sphinx 3.0. Use "Parameters" instead
of "Attributes" in functions. Move docstrings to the corresponding
functions if they are declared.
@jngrad
Exclude Sphinx version 3.0.0
c3ecb57 
A bug ignores the value of `autodoc_mock_imports` in conf.py,
leading to several "ValueError: wrapper loop when unwrapping ...".
@jngrad jngrad force-pushed the new_images_github branch from ffe47eb to c3ecb57 Compare April 8, 2020 21:51
@jngrad
Copy link
Member Author

jngrad commented Apr 8, 2020

The Sphinx CI failure will be fixed by espressomd/docker#173. The Sphinx and Travis changes in this PR will have to be cherry-picked in the 4.1.3 branch.

@jngrad jngrad added this to the Espresso 4.1.3 milestone Apr 8, 2020
@KaiSzuttor
Copy link
Member 

make[2]: *** No rule to make target '/usr/include/boost/align/detail/address.hpp', needed by 'src/core/CMakeFiles/EspressoCore.dir/virtual_sites/EspressoCore_generated_lb_inertialess_tracers_cuda.cu.o'.  Stop.

whats wrong here?

@KaiSzuttor
Copy link
Member

could you please also update the travis docker image

@jngrad
Copy link
Member Author

jngrad commented Apr 9, 2020 •
edited
Loading

Both the CI Linter and the GitLab CI docs are unreliable sources, it seems.

Replacing the deprecated syntax for the global image: (031594c) failed because it defaults to the ubuntu image.

--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -5 +5,2 @@ variables:
-image: docker.pkg.github.com/espressomd/docker/ubuntu-18.04:a1192b35590a1a474c55fe1e9a1e6c25758454ea
+default:
+  image: docker.pkg.github.com/espressomd/docker/ubuntu-18.04:a1192b35590a1a474c55fe1e9a1e6c25758454ea

Yet, from the GitLab CI documentation:

Defining image, services, cache, before_script, and after_script globally is
deprecated. Support could be removed from a future release. Use default: instead.

Replacing the content of the image: tag by an environment variable (07169da) also failed, even though it's known to be possible (gitlab-org/gitlab-foss#20383) and the CI Linter didn't raise warnings.

@jngrad jngrad force-pushed the new_images_github branch from 031594c to 083bc12 Compare April 9, 2020 11:47
@KaiSzuttor
Copy link
Member

the CI linter only checks yaml syntax not features

@jngrad jngrad mentioned this pull request Apr 9, 2020
Closed
@fweik fweik self-assigned this Apr 9, 2020
@jngrad jngrad added the automerge Merge with kodiak label Apr 9, 2020
@kodiakhq kodiakhq bot merged commit 48ba8d1 into espressomd:python Apr 9, 2020
@jngrad jngrad deleted the new_images_github branch January 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor left review comments

@fweik fweik fweik approved these changes

Assignees

@fweik fweik

Labels
automerge Merge with kodiak DevOps Documentation
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jngrad @KaiSzuttor @fweik