Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instruction for mac #3732

Merged
merged 3 commits into from
May 26, 2020

Conversation

KaiSzuttor
Copy link
Member

as reported by C. Holm

@fweik
Copy link
Contributor

fweik commented May 26, 2020

@mkuron can you maybe have a look at the command change, I don't understand that ports stuff...

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #3732 into python will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3732   +/-   ##
======================================
- Coverage      89%     89%   -1%     
======================================
  Files         548     548           
  Lines       24455   24431   -24     
======================================
- Hits        21779   21756   -23     
+ Misses       2676    2675    -1     
Impacted Files Coverage Δ
src/core/thermostat.hpp 89% <0%> (-2%) ⬇️
src/core/integrators/brownian_inline.hpp 90% <0%> (-1%) ⬇️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️
src/core/constraints/ShapeBasedConstraint.cpp 88% <0%> (-1%) ⬇️
src/core/forces_inline.hpp 90% <0%> (-1%) ⬇️
src/core/forces.cpp 100% <0%> (ø)
src/core/Particle.hpp 100% <0%> (ø)
src/core/integrators/langevin_inline.hpp 100% <0%> (ø)
src/core/unit_tests/thermostats_test.cpp 100% <0%> (ø)
src/core/constraints/HomogeneousMagneticField.cpp 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4278feb...a32d078. Read the comment docs.

@mkuron
Copy link
Member

mkuron commented May 26, 2020

Cannot confirm this. The documentation was correct as-is. Maybe he needs to update his MacPorts. I believe that was changed a few months ago.

$ port installed openmpi*
  openmpi-default @4.0.1_1 (active)
$ port select --list mpi
Available versions for mpi:
	none
	openmpi-mp (active)

@KaiSzuttor
Copy link
Member Author

Even if the documentation is correct in some cases, it obviously does not cover all macport environments.

@fweik
Copy link
Contributor

fweik commented May 26, 2020

I'd rather have it not reference fortran if not needed...

Copy link
Member

@mkuron mkuron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, he is right. I seem to have had an OpenMPI package without Fortran bindings.

$ port install openmpi-default +gcc10
$ port select --list mpi
Available versions for mpi:
	none
	openmpi-mp-fortran (active)

The +gcc10 variant is the default, so Fortran bindings will be installed by default.

@fweik
Copy link
Contributor

fweik commented May 26, 2020

So the updated version is correct, yes?

@fweik fweik added the automerge Merge with kodiak label May 26, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone May 26, 2020
@kodiakhq kodiakhq bot merged commit 78edce9 into espressomd:python May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants