Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stokesian Dynamics build system #3896

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fix Stokesian Dynamics build system #3896

merged 1 commit into from
Sep 16, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Sep 15, 2020

Description of changes:

  • fix an incorrect conditional that lead CMake to fetch Stokesian Dynamics even though its dependencies were not found

christophlohrmann
christophlohrmann approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@christophlohrmann christophlohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@jngrad jngrad mentioned this pull request Sep 15, 2020
Closed
@jngrad jngrad added the automerge Merge with kodiak label Sep 16, 2020
@kodiakhq kodiakhq bot merged commit 07f2a3a into espressomd:python Sep 16, 2020
@jngrad jngrad deleted the fix-stokesian-cmake branch January 18, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophlohrmann christophlohrmann christophlohrmann approved these changes

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix CMake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jngrad @KaiSzuttor @christophlohrmann